Feat/add arm64 image builds #664
Conversation
Note: this also automagically pushes the images using buildx as they are not imported to the actual docker system anymore. Signed-off-by: Matthias Riegler <[email protected]>
xvzf
force-pushed
the
feat/add-arm64-image-builds
branch
from
7bb66d8 to
84191b4
Compare
|
Thank you the PR. It is indeed a valid approach to just build the current Alpine based system for arm64. And I'm inclined to eventually merge it until we're ready with the Debian based approach. But not in the state it currently is, because your PR does only half the job, unfortunatley. It lacks the adjustments to the automated builds, i.e. to our GitHub actions. Do you have the capacity to look into it? Don't worry if you dont. But if you have, please don't proceed just now! First I would like to discuss with @tobiasge how we want to proceed with the Debian based approach. (E.g. whether we find the resources to push it forward anytime soon or whether this approach would be a good intermediate solution.) Also – at least for now – I would suggest to not set the platforms by default (see https://github.com/netbox-community/netbox-docker/pull/664/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823R208). |
|
The Debian based approach still has the problem with the Postgres client that won't install correctly in the ARM64 image. From the linked issue I don't see a solution for that coming soon. So if we do want do provide an ARM64 image, I think this is a good intermediate solution. (With your requested change added). |
|
Superseded by #797 |
Duplicate of #604 with a different approach
This PR replaces the
docker buildwithdocker buildxin order to build a multi-arch docker image. This also automagically pushes the images using buildx as they are not imported to the actual docker system anymore.It's not changing the Dockerfile and works on M1(Pro) Macs as well as a regular x86 ubuntu server. I'm just not sure how fast GH Actions is.
Signed-off-by: Matthias Riegler [email protected]
Related Issue:
New Behavior
Contrast to Current Behavior
--push-onlyoption is gone based on the fact this is usingdocker buildxDiscussion: Benefits and Drawbacks
Arm64 is evolving; this e.g. allows the image to run on the AWS Graviton EC2 machines.
Proposed Release Note Entry
Double Check
developbranch.